cvs commit: src/sys/dev/bge if_bge.c

[Oleg Bulyzhin]

On Thu, Feb 02, 2006 at 11:01:42AM +0200, Mihail  Balikov wrote:
> in bge_poll_locked() , when you detect link state change,
> why don't you call bge_link_upd() immediately, instead of waiting for next
> POLL_AND_CHECK ?

bge_link_upd() is rather expensive. Some versions of bcm570x chip have
semi-broken statusword - they always report link event, so you will get HZ/sec
calls of bge_link_upd() (which involves ~6 pci register reads for copper nics).

Anyway, you can tweak kern.polling.reg_frac in order to detect link events
earlier.

> 
> 
> ----- Original Message ----- 
> From: "Oleg Bulyzhin" <oleg at FreeBSD.org>
> To: <src-committers at FreeBSD.org>; <cvs-src at FreeBSD.org>;
> <cvs-all at FreeBSD.org>
> Sent: Wednesday, February 01, 2006 4:41 PM
> Subject: cvs commit: src/sys/dev/bge if_bge.c
> 
> 
> > oleg        2006-02-01 14:41:08 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/dev/bge          if_bge.c
> >   Log:
> >   Since bge_rxeof() & bge_txeof() depends on status block data it should
> be
> >   synchronized on every call of bge_poll_locked().
> >
> >   Suggested by:   Mihail Balikov <mihail.balikov AT interbgc DOT com>
> >   Approved by:    glebius (mentor)
> >   MFC after:      3 days
> >
> >   Revision  Changes    Path
> >   1.121     +16 -14    src/sys/dev/bge/if_bge.c
> > _______________________________________________
> > cvs-src at freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/cvs-src
> > To unsubscribe, send any mail to "cvs-src-unsubscribe at freebsd.org"
> >
> >
> > __________ NOD32 1.1390 (20060201) Information __________
> >
> > This message was checked by NOD32 antivirus system.
> > http://www.eset.com
> >
> >

-- 
Oleg.