cvs commit: src/sys/kern tty.c

[Attilio Rao]

2006/12/20, Martin Blapp <mb at imp.ch>:
>
> Hi,
>
> > No, it drops Giant for all the time it sleeps.
> > Maybe the race is somewhere else.
>
> Yep, you are correct. It drops Giant for all the time.
>
> And during this time the session could be cleared
> somewhere else because we don't held GIANT anymore.
>
> I don't understand your problem ?

Quote:
"Log:
 Giant might have been temporarily dropped while waiting for
proctree_lock, allowing for an
 intervening tty_close() that cleared tp->t_session."

so, as you have seen, when a thread is waiting against proctree_lock
it doesn't held Giant. I don't understand the sense of your commit.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein