moving pgrep and pkill

[Brooks Davis]

On Sun, Aug 20, 2006 at 08:06:37AM +0400, Yar Tikhiy wrote:
> On Sat, Aug 19, 2006 at 04:48:51PM -0400, Garance A Drosehn wrote:
> > At 12:32 PM +0400 8/19/06, Yar Tikhiy wrote:
> > >On Fri, Aug 18, 2006, Brooks Davis wrote:
> > > > On Fri, Aug 18, 2006, Yar Tikhiy wrote:
> > > > > On Fri, Aug 18, 2006, Brooks Davis wrote:
> > > > > > On Fri, Aug 18, 2006, Yar Tikhiy wrote:
> > > > > > | On Fri, Aug 18, 2006, Dag-Erling Sm?rgrav wrote:
> > > > > > | > In a commit msg, Yar Tikhiy <yar at FreeBSD.org> writes:
> > > > > > | > >   Log:
> > > > > > | > >   The ps(1) command is unfriendly to scripts by default
> > > > > > | > >   because it limits the width of its output to the value
> > > > > > | > >   of $COLUMNS, or what TIOCGWINSZ reports, or 79 columns.
> > > > > > | > >   We should specify -ww to ps(1) so that it removes the
> > > > > > | > >   limit and prints lines in full.  Otherwise very long
> > > > > > | > >   command pathnames could be mishandled, e.g.,
> > > > > > | > >   by _find_processes().
> > > > > > | >
> > > > > > | > or perhaps _find_processes() should use pgrep(1) instead
> > > > > > | > of ps(1).
> > > > > > |
> > > > > > | I considered that but had to stick to ps(1) because pgrep
> > > > > > | was in /usr/bin while ps was in /bin.  The use of /usr/bin
> > > > > > | tools should be very limited in rc.subr(8).  OTOH, pgrep
> > > > > > | uses /lib libs only, which makes it possible to transfer
> > > > > > | pgrep+pkill to /bin if we can stand the growth of / by
> > > > > > | some 50 kbytes.
> > > > > >
> > > > > > I think that's appropriate since pgrep is such an obvious
> > > > > > fit for this sort of thing.  I think we'll want to consider
> > > > > > compatability symlinks due to existing hardcoded paths in
> > > > > > scripts.
> > 
> > 
> > I do not mind if `pgrep' and `pkill' are moved to /bin.  Note
> > that these were added to /usr because that's where they exist
> > on NetBSD, OpenBSD, Solaris and Linux.  So we're not just
> > talking about hardcoded-paths in a few scripts that FreeBSD
> > users might have written for use only on FreeBSD.  So, I expect
> > we will want symlinks to remain in /usr, forever, if we move
> > the programs to /bin.
> > 
> > (Moving them does seem reasonable to me. I'm just saying why
> > they were put in /usr in the first place...)
> 
> Thank you!  I'll add a comment to src/usr.bin/pkill/Makefile so that
> the SYMLINKS lines aren't removed without thorough consideration.

Sounds good.  I don't think it's a problem to have the compat links
around, we're talking two inodes after all. :)

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060820/ee918ad7/attachment.pgp