cvs commit: src/sys/conf kern.post.mk kmod.mk src/sys/modules/if_ef Makefile src/sys/modules/if_ppp Makefile src/sys/modules/netgraph/mppc Makefile src/sys/modules/sound/sound Makefile

[Bruce Evans]

On Tue, 15 Aug 2006, Ruslan Ermilov wrote:

> On Tue, Aug 15, 2006 at 09:40:36AM +1000, Bruce Evans wrote:
>> On Mon, 14 Aug 2006, Dag-Erling Smorgrav wrote:

>>> Revision  Changes    Path
>>> 1.96      +1 -1      src/sys/conf/kern.post.mk
>>> 1.210     +2 -2      src/sys/conf/kmod.mk
>>> 1.14      +4 -4      src/sys/modules/if_ef/Makefile
>>> 1.36      +3 -3      src/sys/modules/if_ppp/Makefile
>>> 1.14      +1 -1      src/sys/modules/netgraph/mppc/Makefile
>>> 1.19      +1 -1      src/sys/modules/sound/sound/Makefile
>>
>> I use echo -n for one of these.  "echo" is less cryptic than ">", and
>> is probably faster since /bin/echo is smaller than /bin/sh and is used
>> enough to keep it cached.
>>
> make(1) will still use sh(1) when it sees ">", so what's the point?

Oops.  For some reason I thought make handled redirection internally,
and ktrace didn't seem to show sh.

>> In sound/Makefile, the cleanup should be to remove the touching (now
>> emptying) since the touching used to be just worse than the default of
>> emptying and is now just the same as the default (but takes extra code).
>>
> No.  It has a preceding comment explaining why it's needed on sparc64:
> to always build sound.ko without isadma dependency; see rev. 1.16 by
> marius at .

Hmm, that's ugly.  1.16 seems to have the opposite effect in the non-sparc64
case -- it forces isa for sound.ko even in the KERNBUILDDIR case with isa
not in the kernel.  All targets for opt_foo.h in module makefiles similarly
force the kernel options to not be used.  However, it is a bug to ever use
kernel options in modules :-).

Bruce