cvs commit: src/libexec/telnetd Makefile

Yar Tikhiy yar at comp.chem.msu.su
Tue Aug 1 09:24:49 UTC 2006


On Mon, Jul 31, 2006 at 07:19:13PM -0600, M. Warner Losh wrote:
> In message: <20060731170830.GC50797 at comp.chem.msu.su>
>             Yar Tikhiy <yar at comp.chem.msu.su> writes:
> : On Mon, Jul 31, 2006 at 09:30:58AM -0700, Sam Leffler wrote:
> : > Yar Tikhiy wrote:
> : > > yar         2006-07-31 13:20:44 UTC
> : > > 
> : > >   FreeBSD src repository
> : > > 
> : > >   Modified files:
> : > >     libexec/telnetd      Makefile 
> : > >   Log:
> : > >   telnetd(8) doesn't really go to the crunched floppies,
> : > >   so its Makefile needn't test for RELEASE_CRUNCH.
> : > 
> : > What about folks building crunchgen'd images w/ telnetd; is there an
> : > equivalent way to do the same thing w/ the new build knobs?
> : 
> : I'd suggest using WITHOUT_CRYPT=yes, it will have the same effect
> : for telnetd.  Anyway, the RELEASE_CRUNCH knob's coverage is rather
> : limited, it's respected by only those parts of src/ that are included
> : in the standard boot floppies--telnetd was just an exception.  The
> : other exception is inetd, which puts its IPSEC stuff under
> : RELEASE_CRUNCH.  The better way would be to introduce the
> : MK_IPSEC_SUPPORT knob.  RELEASE_CRUNCH could be mostly handled in
> : a single place then.  Few tools build in a really special way if
> : RELEASE_CRUNCH is defined; most tools just have crypto, IPX etc
> : stuff omitted from them.
> 
> We should test "MK_CRYPT" or "MK_IPSEC_SUPPORT" in the makefiles, set
> via WITH/WITHOUT_CRYPT/IPSEC_SUPPORT in configuration files.

And those Makefiles that decide whether to do something special
depending on the status of RELEASE_CRUNCH can use a more general
and convenient knob name, e.g., MK_MINIMAL (would be WITH_MINIMAL
in src.conf).

-- 
Yar


More information about the cvs-src mailing list