cvs commit: src/sys/dev/bge if_bge.c

Scott Long scottl at samsco.org
Sat Apr 15 16:06:36 UTC 2006


Oleg Bulyzhin wrote:
> On Sat, Apr 15, 2006 at 08:13:07AM +0000, Scott Long wrote:
> 
>>scottl      2006-04-15 08:13:07 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/dev/bge          if_bge.c 
>>  Log:
>>  Fix the interrupt handler to do the mandatory PCI flush before looking at
>>  DMA memory.  The could contribute towards missed link state changes under
>>  heavy bus load.
>>  
>>  Revision  Changes    Path
>>  1.126     +10 -14    src/sys/dev/bge/if_bge.c
> 
> 
> Should not we do the same for polling case?
> 

No, because there is no race with the interrupt signal when you're
polling.  The data is in host memory or it isn't, and doing a bus
flush on every loop would be highly counter productive.

Scott



More information about the cvs-src mailing list