cvs commit: src/sys/dev/amr amr.c amr_pci.c amrvar.h

[Scott Long]

Nate Lawson wrote:

> Paul Saab wrote:
> 
>> ps          2006-04-08 02:23:27 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/dev/amr          amr.c amr_pci.c amrvar.h   Log:
>>   Close a pesky race where after checking the BUSY flag in 
>> amr_wait_command,
>>   the completion of the command can occur before tsleep is called and
>>   the command ends up blocking forever since the wakeup has already
>>   been called.
>>     Submitted by:   ups
>>     Revision  Changes    Path
>>   1.76      +19 -6     src/sys/dev/amr/amr.c
>>   1.35      +1 -0      src/sys/dev/amr/amr_pci.c
>>   1.31      +1 -0      src/sys/dev/amr/amrvar.h
> 
> 
> This would be a good audit task to do on the whole kernel.  There are 
> very few legitimate uses of tsleep() these days.
> 

There are legitimate uses, this just isn't one of them.

Scott