cvs commit: src/sys/nfsserver nfs_srvsubs.c

[Chuck Lever]

cel         2006-04-05 00:33:33 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_5)
    sys/nfsserver        nfs_srvsubs.c 
  Log:
  rick says:
  
  The following bug was just identified in OpenBSD and it looks like the same
  bug exists in the other BSDen NFS servers.
  
  A Linux client (don't know which version, but you can look at
          http://bugzilla.kernel.org/show_bug.cgi?id=6256)
  does a Setattr of mtime to the server's time, where the file is mode 0664 and
  the client user has group access (ie. caller is not the file owner).
  
  The BSD servers fail the Setattr with EPERM, since the VA_UTIMES_NULL flag
  isn't set before doing the VOP_SETATTR.
  
  It seems to me that this should be allowed, since it is allowed for a local
  utimes(2). If so, the fix is to set VA_UTIMES_NULL for the
  "set-time-to-server-time" cases of setting atime and/or mtime.
  
  MFC of revision 1.140 to RELENG_5.
  
  Submitted by:   rick at snowhite.cis.uoguelph.ca
  Reviewed by:    cel
  Approved by:    re (scottl), silby
  
  Revision   Changes    Path
  1.131.2.2  +6 -0      src/sys/nfsserver/nfs_srvsubs.c