cvs commit: src/sys/netipsec ipsec_mbuf.c

Andre Oppermann andre at freebsd.org
Mon Sep 26 13:50:11 PDT 2005


Sam Leffler wrote:
> 
> Andre Oppermann wrote:
> > andre       2005-09-26 20:35:45 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/netipsec         ipsec_mbuf.c
> >   Log:
> >   Replace custom mbuf writeability test with generic M_WRITABLE() test
> >   covering all edge cases too.
> 
> I vaguely recall that M_WRITEABLE did exist when I wrote that code but
> it did not do the right thing.  I'm not sure why you needed to make this
> change but beware of unexpected side effects.

The test in question tries to determine whether to copy the mbuf to make
to safe for modification.  The old did not respect the M_RDONLY for example.
M_WRITABLE() correctly tests for all cases.

-- 
Andre


More information about the cvs-src mailing list