cvs commit: src/sys/sys bus.h rman.h types.h src/sys/kern
subr_bus.c
M. Warner Losh
imp at bsdimp.com
Sat Sep 24 17:37:17 PDT 2005
In message: <4335D760.9080007 at root.org>
Nate Lawson <nate at root.org> writes:
: Poul-Henning Kamp wrote:
: > --- src/sys/sys/bus.h:1.71 Sun Sep 18 01:32:09 2005
: > +++ src/sys/sys/bus.h Sat Sep 24 19:31:10 2005
: > @@ -85,11 +85,6 @@
: > const char *__type, const char *__data);
: > void devctl_queue_data(char *__data);
: >
: > -/*
: > - * Forward declarations
: > - */
: > -typedef struct device *device_t;
: > -
: > /**
: > * @brief A device driver (included mainly for compatibility with
: > * FreeBSD 4.x).
:
: > diff -u src/sys/sys/types.h:1.92 src/sys/sys/types.h:1.93
: > --- src/sys/sys/types.h:1.92 Tue May 31 15:18:17 2005
: > +++ src/sys/sys/types.h Sat Sep 24 19:31:10 2005
: > @@ -285,6 +285,7 @@
: > typedef __uintfptr_t uintfptr_t;
: > typedef __uint64_t uoff_t;
: > typedef struct vm_page *vm_page_t;
: > +typedef struct device *device_t;
: >
: > #define offsetof(type, field) __offsetof(type, field)
:
: I don't think our device_t definition belongs in sys/types.h. It is
: opaque for a reason.
It is still opaque.
Warner
More information about the cvs-src
mailing list