cvs commit: src/sys/conf files kern.pre.mk

[John Baldwin]

On Sunday 11 September 2005 02:01 am, David O'Brien wrote:
> On Sat, Sep 10, 2005 at 10:06:28PM -0700, Sam Leffler wrote:
> > David E. O'Brien wrote:
> > >obrien      2005-09-11 03:38:19 UTC
> > >
> > >  FreeBSD src repository
> > >
> > >  Modified files:
> > >    sys/conf             files kern.pre.mk
> > >  Log:
> > >  Don't pollute the entire kernel build with -I$S/contrib/dev/ath and
> > >  -I$S/contrib/dev/ath/freebsd.  "ATH_BUILDING_FROM_SOURCE" can be
> > > defined to
> > >  globally get back -I$S/contrib/dev/ath.
> >
> > Thanks for explicitly ignoring my request for you NOT to do this.  It's
> > really great how you do these drive-by commits that do nothing but f*ck
> > up people's development environment.
> > 	Sam
>
> I did my best to take your needs into account.  I even asked you to
> propose a patch when you didn't like the ones I sent you - your response
> was "David, I have no time to waste on stuff like this."
>
> "-INCLUDES+= -I$S/contrib/dev/ath" should never have been in the public
> FreeBSD source tree as not a single file in /usr/src/sys needed it to
> compile.  We don't commit Yahoo!'s, The Weather Channel, Interjet's or
> any other vendor-specific needs into the open source /usr/src.  I think
> you're more than able to stick "ATH_BUILDING_FROM_SOURCE=yes" in the
> /etc/make.conf of the machines you build the ath(4) HAL on.
>
> I'm sorry you don't see that we shouldn't pollute the kernel build with
> tons of -I's.  It was getting out of hand that every one felt they could
> add yet another global -I with every new code import rather than edit
> their code to build in our tree correctly.

David, how did having -Ifoo waste your time?  Also, we do put vendor-specific 
needs into the tree all the time. :)  How do you think the limited ACPI 
support for 4.x was done?  That wasn't some random act of kindness on my part 
because I was bored, it was something that ${REALJOB} needed.  A lot of work 
on FreeBSD happens because people use it at their workplace and fix the needs 
and problems that come from that use.  You just added some license files to a 
subdirectory for the nve(4) device driver to make a vendor happy yourself 
which was catering to that vendor as other vendors don't require that.  Looks 
rather hyprocritical to me from over in this corner.

I don't see how -Ifoo could have possibly been killing you.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org