cvs commit: src/etc/rc.d devd ipmon newsyslog powerd sendmail

[Yar Tikhiy]

On Sat, Oct 29, 2005 at 10:57:01AM -0700, Doug Barton wrote:
> Yar Tikhiy wrote:
> > yar         2005-10-28 16:55:38 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     etc/rc.d             devd ipmon newsyslog powerd sendmail 
> >   Log:
> >   Use ${name} in pathnames where appropriate.
> >   The sendmail script already was on this way,
> >   but it didn't reach the end of it yet.
> >   
> >   Revision  Changes    Path
> >   1.8       +1 -1      src/etc/rc.d/devd
> >   1.14      +1 -1      src/etc/rc.d/ipmon
> >   1.4       +1 -1      src/etc/rc.d/newsyslog
> >   1.3       +1 -1      src/etc/rc.d/powerd
> >   1.16      +3 -3      src/etc/rc.d/sendmail
> > 
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/devd.diff?&r1=1.7&r2=1.8&f=h
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/ipmon.diff?&r1=1.13&r2=1.14&f=h
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/newsyslog.diff?&r1=1.3&r2=1.4&f=h
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/powerd.diff?&r1=1.2&r2=1.3&f=h
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/sendmail.diff?&r1=1.15&r2=1.16&f=h
> 
> Were there reasons other than semantic correctness for this change? I am
> generally hesitant to churn things like this where nothing is broken.

Indeed, the change looks like a cosmetic one.  However, a similar
issue in rc.d/ppp-user drew our attention to a somewhat greater
problem with the script -- see this thread:

http://lists.freebsd.org/pipermail/freebsd-rc/2005-October/000316.html

Therefore I decided that the rest of rc.d scripts should follow the
style of using ${name} wherever appropriate, too.  Most of them did
so already, and I just touched a few remaining ones.  A consistent
style helps to uncover bugs and problems.

-- 
Yar