cvs commit: src/etc/rc.d ike named ppp-user sshd

[John Baldwin]

On Thursday 27 October 2005 05:19 am, Yar Tikhiy wrote:
> On Thu, Oct 27, 2005 at 10:21:16AM +0200, Pawel Jakub Dawidek wrote:
> > On Thu, Oct 27, 2005 at 11:14:56AM +0400, Yar Tikhiy wrote:
> > +> On Thu, Oct 27, 2005 at 08:33:53AM +0200, Pawel Jakub Dawidek wrote:
> > +> > On Sun, Oct 23, 2005 at 02:06:53PM +0000, Yar Tikhiy wrote:
> > +> > +> yar         2005-10-23 14:06:53 UTC
> > +> > +>
> > +> > +>   FreeBSD src repository
> > +> > +>
> > +> > +>   Modified files:
> > +> > +>     etc/rc.d             ike named ppp-user sshd
> > +> > +>   Log:
> > +> > +>   Don't be lazy, set the "command" variable even if
> > +> > +>   /etc/defaults/rc.conf will provide foo_program, too.
> > +> > +>   By specifying "command" we explicitly say that we're
> > +> > +>   going to rely on rc.subr(8) default methods, and
> > +> > +>   rc.subr(8) will take advantage of this soon.
> > +> > +>
> > +> > +>   The majority of our rc.d scripts already set "command"
> > +> > +>   if appropriate, so fix just the non-compliant handful.
> > +> > [...]
> > +> > +>  name="named"
> > +> > +>  rcvar=`set_rcvar`
> > +> > +> +command="/usr/sbin/${name}"
> > +> > [...]
> > +> > +>  name="ppp"
> > +> > +>  rcvar=`set_rcvar`
> > +> > +> +command="/usr/sbin/ppp"
> > +> > [...]
> > +> > +>  name="sshd"
> > +> > +>  rcvar=`set_rcvar`
> > +> > +> +command="/usr/sbin/${name}"
> > +> >
> > +> > Any reason you didn't used ${name} in ppp case?
> > +>
> > +> I was just blinded by my being solid sure that $name was "ppp-user".
> > +> Nowever, now I'm in doubt whether $name should be "ppp".  The script
> > +> is named ppp-user and it PROVIDEs ppp-user, hence sysadmins can
> > +> rightfully assume that its rc.conf.d file is ppp-user, too.  Such
> > +> assumption will be broken since it is $name that is passed to
> > +> load_rc_config.  I think $name should be changed to "ppp-user" in
> > +> CURRENT.  This will introduce minor incompatibility, but also
> > +> eliminate a source of further confusion.
> >
> > It is confusing, but maybe we should rename ppp-user to ppp?
> > I'm not sure how well sh(1) will handle things like
> > ppp-user_enable="YES", etc.
>
> Yes, this is much better than my lame proposal because so we will
> have to worry about neither variable naming nor compatibility with
> installations using ppp and rc.conf.d at once.  We change the PROVIDE
> line and fix all dependent rc.d scripts, then request the repocopy
> of ppp-user to ppp, fix /etc/netstart, and finally kill the old
> file.  Does this plan look OK?
>
> P.S. Looks like it's time to move this thread to -rc, setting
> Mail-Followup-To accordingly.

Yeah, I was actually surprised it was called /etc/rc.d/ppp-user instead 
of /etc/rc.d/ppp when I went to setup pppoe at home yesterday.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org