cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c

[David O'Brien]

On Mon, Oct 17, 2005 at 12:08:50PM -0700, Eric Anholt wrote:
> > > On Monday 17 October 2005 01:28 pm, David O'Brien wrote:
> > > >     CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz
> > > > K8-class CPU) ..
> > > >     Physical/Logical cores: 2/2
> > > >     ..
> > > >     FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs
> > > >      cpu0 (BSP): APIC ID:  0
> > > >      cpu1 (AP): APIC ID:  1
> > > >      cpu2 (AP): APIC ID:  2
> > > >      cpu3 (AP): APIC ID:  3
>
> Apparently David interpeted the "Physical/Logical cores: 2/2" as two
> physical cores plus two additional logical cores.  I didn't, but I could
> see how (since this per-cpu information printed isn't actually printed
> per cpu) it could be interpreted this way on a dual-cpu system.
> 
> I think that this would be useful information to be printing in general
> (not just on really-HTT systems), since it would clarify what seeing
> "cpu[0-3]: APIC ID..." printed out actually means when you're just
> taking a look at some system and wondering how many cores it has.

I guess I just don't see why for non-Intel non-HTT systems what this
information provides that already isn't printed out.  The dmesg I posted
shows four APIC ID's.  Other than my electric company no one (people or
FreeBSD SW) should care that I have dual-core CPU's.  If this information
doesn't provide any additional information to the viewer, we shouldn't
clutter up dmesg further.  On Intel HTT systems, the output could in fact
be useful.  Not having access to a dual-core HTT Intel system right now,
I'm not qualified to say.

-- 
-- David  (obrien at FreeBSD.org)