cvs commit: src/sys/libkern strtok.c src/sys/sys libkern.h src/sys/conf files

[Nate Lawson]

Pawel Jakub Dawidek wrote:
> On Thu, Oct 06, 2005 at 10:36:39AM -0700, Nate Lawson wrote:
> +> Stefan Farfeleder wrote:
> +> >On Thu, Oct 06, 2005 at 04:44:54PM +0200, Pawel Jakub Dawidek wrote:
> +> >>On Thu, Oct 06, 2005 at 03:27:40PM +0200, Stefan Farfeleder wrote:
> +> >>+> On Thu, Oct 06, 2005 at 11:10:10AM +0000, Pawel Jakub Dawidek wrote:
> +> >>+> > pjd         2005-10-06 11:10:10 UTC
> +> >>+> > +> >   FreeBSD src repository
> +> >>+> > +> >   Modified files:
> +> >>+> >     sys/sys              libkern.h +> >     sys/conf             files +> >   Added files:
> +> >>+> >     sys/libkern          strtok.c +> >   Log:
> +> >>+> >   Add strtok() and strtok_r() function to libkern.
> +> >>+> +> Wouldn't it be better to have strsep() instead?
> +> >>Actually we do have strsep() libkern already...
> +> >Oops.  Can you please change nfs_diskless.c to use strsep()?  I think
> +> >it's a mistake to add non-reentrant functions to libkern.
> +> >Stefan
> +> 
> +> Agreed.
> 
> I wanted to use it to parse options for NFS root file system.
> There is no race risk there, but I added also strtok_r() function.
> 
> That was my thinking back then. I was wrong, I should look closer for
> strsep() in libkern and just use it. Sorry for the mess I'll back it
> out after some testing of setsep() version. 

Thanks.

-- 
Nate