cvs commit: src/etc/rc.d hcsecd sdpd

[Yar Tikhiy]

On Fri, Nov 18, 2005 at 10:03:04AM -0800, Maksim Yevmenkin wrote:
> 
> > > emax        2005-11-15 20:36:26 UTC
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     etc/rc.d             hcsecd sdpd
> > >   Log:
> > >   Revise hcsecd(8) and sdpd(8) rc.d scripts.
> > >
> > >   - Have both scripts automatically kldload ng_btsocket(4). I did not want to
> > >     do it, but its easier for users and it seems other scripts do similar things;
> >
> > You need not override the start method for such a hack.
> > Just put the kldload in the prestart method.
> 
> actually, i had to. i have defined sdpd_group and sdpd_user variables,
> and, by default, run_rc_command() checks if ${name}_group and
> ${name}_user are defined and uses su(1) to start ${command}.
> 
> i guess, i could have used prestart and undefine  sdpd_group and
> sdpd_user before calling run_rc_command().

I guess different variable names should have been used.
Choosing magic names first and fighting their side-effects
then doesn't look good to me.

> > In addition, you could check if the module is loaded already.
> > See the pf* scripts for an example.
> 
> well, yes, i could. but a saw a couple of bad examples in /etc/rc.d :)
> that do it without checking. if it really bugs people, i could fix
> this.

It's almost never too late to fix slips in our computer programs,
unlike in some other areas of life ;-)

-- 
Yar