cvs commit: src/sys/dev/sound/pcm channel.c

[Stefan Farfeleder]

On Tue, Nov 15, 2005 at 08:23:06PM +0800, Ariff Abdullah wrote:
> On Tue, 15 Nov 2005 09:58:52 +0000 (GMT)
> Robert Watson <rwatson at FreeBSD.org> wrote:
> > 
> > On Tue, 15 Nov 2005, Alexander Leidinger wrote:
> > 
> > >>  Modified files:
> > >>    sys/dev/sound/pcm    channel.c
> > >>  Log:
> > >>  Unbreak kernel builds.
> > >> 
> > >>  Submitted by:   arr
> > >
> > > Hos does the change from "min & (min-1) == 0" to "(min & (min-1))
> > > == 0"  fix the building of a kernel (what was the error message
> > > from gcc)?
> > 
> > Probably a combination of -Wall and -Werror, which generally
> > generates a  warning along the following lines:
> > 
> >      warning: suggest parentheses around comparison in operand of &
> > 
> That means, warnings caused by excessive inlining while compiling
> maestro.c should also break the build if WARNS=1, right? Has anybody
> encounter and getting annoyed by this?

No, function inlining doesn't change the semantics of expressions.

Stefan