cvs commit: src/lib/libstand Makefile

[Maxim Sobolev]

Ruslan Ermilov wrote:
> Hi,
> 
> On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote:
> 
>>sobomax     2005-05-29 21:05:58 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    lib/libstand         Makefile 
>>  Log:
>>  Add missed ${.CURDIR}/../../contrib/bzip2 into include search path, otherwise
>>  old version of bzlib.h can be picked up from the /usr/include.
>>  
>>  Revision  Changes    Path
>>  1.51      +1 -1      src/lib/libstand/Makefile
>>
> 
> Changes like this, while harmless, unnecessarily pollute makefiles.
> During buildworld we first install new headers then build new
> libraries then the rest.  When doing standalone compiles, the same
> procedure should generally be followed.  (Otherwise, you'd end up
> changing every utility's makefile that uses libstand to add this
> -I to CFLAGS.)

This is incorrect assertion since libstand hides implementation details, 
so that it is not necessary to include bzlib.h into code which uses 
libstand.

> I have only problem with the above change: it has a wrong attribution
> in the commit log.  The correct commit log would be: "aid in lazy
> standalone builds by always picking up a fresh copy of bzlib.h from
> sources".

-Maxim