cvs commit: src/usr.sbin/chkgrp chkgrp.8 chkgrp.c

Maxime Henrion mux at FreeBSD.org
Thu May 26 04:59:07 PDT 2005


Maxime Henrion wrote:
> Ollivier Robert wrote:
> > roberto     2005-05-26 10:57:04 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     usr.sbin/chkgrp      chkgrp.8 chkgrp.c 
> >   Log:
> >   - Add further functionality to check for invalid characters
> >   - Remove keyword 'continue' for more indepth error reporting
> >     on each line
> >   - WARNS 6 Clean
> 
> As I said to Liam some time ago, the use of strcspn() in this file is
> bogus.  It's not Liam's fault, he only moved this code, and didn't
> introduce it.  However, it would be nice to fix this since calling
> strcspn(foo, " \t") has no chances of working as expected :-).

Actually, I got confused...  This is perfectly correct.

Maxime


More information about the cvs-src mailing list