cvs commit: src/usr.bin/make job.c job.h main.c

[Max Okumoto]

Harti Brandt <hartmut.brandt at dlr.de> writes:

> On Tue, 24 May 2005, Max Okumoto wrote:
>
> MO>Harti Brandt <hartmut.brandt at dlr.de> writes:
> MO>[stuff deleted]
> MO>> MO>Harti,
> MO>> MO>
> MO>> MO>Please make sure to attribute patches to DragonFly when you take
> MO>> MO>things from their CVS.  Most of the work is in this patch is yours
> MO>> MO>but there are some changes that appear like they came from the DragonFly
> MO>> MO>tree.
> MO>>
> MO>> Can you point me at what you think came from DragonFly? If you talk about 
> MO>> the ArgArray stuff, then there is the correct attribution in that commit. 
> MO>> The stuff here was fully done by me. I didn't have a look at DragonFly's 
> MO>> make since I got the ArgArray stuff.
> MO>>
> MO>> harti
> MO>
> MO>My mistake, if you are not tracking my work any more.
> MO>It just looked like some minor changes were similar to
> MO>what I did.
>
> Well, as you see from the ArgArray stuff, I'm tracking this when I have 
> time to do so. I was a little bit surprised to see you disappear :-/

Well, I got the impression that didn't want stuff from me.  After
I asked you to revert a change that broke a 20+ patches that I had
pending to send to you.  You ignored the request.  And your response
was to point out that one of the earlier patches had a mistake.
After that, the commits you did later on had gratuious white space
changes, and a double semi colon.  Shrug.

>
> I just had a look at the current DFly sources - there's nothing that 
> resembles the work in that commit.
>
> NB: It looks like you don't set DEFSHELL anymore in the Makefile, but you 
> still use it in job.c. (I still think that having reviews for something so 
> sensible like make makes sense). This unsetenv("ENV") thing is probably a 
> candidate for a new .SHELL attribute.
>
> harti

Thanks I will fix that.

                        Max