cvs commit: src/contrib/top commands.c machine.h top.c src/usr.bin/top machine.c

[Scott Long]

juli mallett wrote:
> * Scott Long <scottl at samsco.org> [ Date: 2005-05-23 ]
> 	[ w.r.t. Re: cvs commit: src/contrib/top commands.c machine.h top.c src/usr.bin/top machine.c ]
> 
>>Brian Fundakowski Feldman wrote:
>>
>>>On Mon, May 23, 2005 at 12:33:44AM -0700, David O'Brien wrote:
>>>
>>>
>>>>On Wed, May 18, 2005 at 01:30:08PM +0000, Giorgos Keramidas wrote:
>>>>
>>>>
>>>>>keramida    2005-05-18 13:30:08 UTC
>>>>>
>>>>>FreeBSD src repository (doc committer)
>>>>>
>>>>>Modified files:
>>>>>  contrib/top          commands.c machine.h top.c 
>>>>>  usr.bin/top          machine.c 
>>>>>Log:
>>>>>Merge the CPU and WCPU columns in a single %6.2f column, add a new 'C'
>>>>>command that toggles between the two and update the ORDER_PCTCPU()
>>>>>macro to sort correctly by the visible "cpu" value.
>>>>
>>>>Having both CPU and WCPU are a lot more useful than showing the number of
>>>>threads.  Out of the top 70 processes I'm running right now, only _1_ is
>>>>multi-threaded.
>>>>
>>>>How about backing all this out and making your toggle be between #threads
>>>>and something else -- with the something else being the default thing
>>>>shown.
>>>>
>>>>I still don't know what was wrong with the 'H' display of top(1) which
>>>>was all about threading.
>>>
>>>
>>>Could you explain what WCPU/CPU are supposed to differentiate?  In years
>>>of using FreeBSD I don't think I've seen them ever be different, so I'm
>>>always left wondering why there's what appears to be wasted screen
>>>real-estate.
>>>
>>
>>man top
>>
>>[...]
>>WCPU, when displayed, is the weighted cpu percentage (this is the  same
>>value that ps(1) displays as CPU), CPU is the raw percentage and is the
>>field that is sorted to determine the order of the processes
>>[...]
>>
>>I'm not sure which FreeBSD you've been using for years, but the numbers 
>>are almost never the same for all of the machines that I have.
> 
> 
> I don't know what machines you're using, but on almost all the FreeBSD
> machines I use, most of the tasks are idle, and thus CPU and WCPU will
> be the same (0.00, 0.00).  As for running tasks, yes, Brian must be
> thinking of something else.  That said, the numbers are almost always
> the same, at least given my sample set.
> 
> juli.

Sorry for not being explicit about idle processes.

Scott