cvs commit: src/usr.bin/top machine.c

[Giorgos Keramidas]

On 2005-05-15 20:27, David O'Brien <obrien at FreeBSD.org> wrote:
>On Mon, May 16, 2005 at 03:40:59AM +0300, Giorgos Keramidas wrote:
>>On 2005-05-15 17:18, David O'Brien <obrien at FreeBSD.org> wrote:
>>>On Sat, Apr 16, 2005 at 03:43:38PM +0000, Giorgos Keramidas wrote:
>>>>   Reduce the width of the THR column to 4 characters, to avoid wrap-around
>>>>   of lines in SMP machines (which are wider), until we have a better way
>>>>   of handling window sizes & columns in top.
>>>>
>>>>   Caught by:      ache, Andre Guibert de Bruet <andy at siliconlandmark.com>
>>>>   Point hat:      keramida
>>>>
>>>>   Revision  Changes    Path
>>>>   1.71      +5 -5      src/usr.bin/top/machine.c
>>>
>>> Please back machine.c back to revsion 1.69, ASAP.
>>> The current top is redicious:
>..snip..
>> Your USERNAME column is too wide (12 columns).  Do you happen to have
>> very long names?
>
> The dovecot port adds a the 'dovecot-auth' user.
> The top(1) code supports 13 character usernames on SMP systems and 15 on
> UP systems.  Your rev 1.70-1.71 changes failed to take that into account.

Because there's nothing to take into account.  The bug is not in the THR
column added by those revisions but in the dynamic resizing of the
USERNAME column :-)

>> If that is true, would it be ok to wait 1-2 days until I have a
>> machine.c version that prints USERNAME using only 8 columns instead of
>> using arbitrarily long columns, like now?
>
> I don't know why to wait 1-2 days.  I made the change in 1 minute.  Or is
> there debate if that change will be acceptable?  If there isn't a debate
> about it, let me know and I'll commit this diff.

I'm not an src committer, so I need a proper review by a real src
committer.  The 1-2 day estimate was the time it has taken in the past
for making the change, testing, testing again, and then getting a review.

If you think that hard-limiting USERNAME to 8 columns is fine, then I'm
all for it, please commit :-)

- Giorgos