cvs commit: src/usr.bin/top machine.c

[Giorgos Keramidas]

On 2005-05-15 17:18, David O'Brien <obrien at FreeBSD.org> wrote:
>On Sat, Apr 16, 2005 at 03:43:38PM +0000, Giorgos Keramidas wrote:
>>   Reduce the width of the THR column to 4 characters, to avoid wrap-around
>>   of lines in SMP machines (which are wider), until we have a better way
>>   of handling window sizes & columns in top.
>>
>>   Caught by:      ache, Andre Guibert de Bruet <andy at siliconlandmark.com>
>>   Point hat:      keramida
>>
>>   Revision  Changes    Path
>>   1.71      +5 -5      src/usr.bin/top/machine.c
>
> Please back machine.c back to revsion 1.69, ASAP.
> The current top is redicious:

I don't know what "redicious" means, but see below.  It may make more
sense to back it out, or it may not.

> rev 1.69:
> ~~~~~~~~~
> last pid: 65534;  load averages:  0.03,  0.06,  0.07    up 7+00:10:18  17:17:07
> 144 processes: 2 running, 140 sleeping, 2 stopped
> CPU states:  0.2% user,  0.0% nice,  0.8% system,  0.6% interrupt, 98.5% idle
> Mem: 200M Active, 2607M Inact, 258M Wired, 121M Cache, 112M Buf, 25M Free
> Swap: 3750M Total, 4K Used, 3750M Free
>
>   PID USERNAME     PRI NICE   SIZE    RES STATE  C   TIME   WCPU    CPU COMMAND
> 51029 obrien        96    0 64112K 62048K CPU0   1   6:13  0.00%  0.00% Xorg
>   283 root          96    0  1796K  1296K select 0   5:05  0.00%  0.00% natd
> 51301 obrien        96    0 13508K  2156K select 0   5:01  0.00%  0.00% xcpusta
>  1627 bind          96    0  4356K  3572K select 1   4:29  0.00%  0.00% named
> 51313 obrien        96    0  9920K  6356K select 0   2:28  0.00%  0.00% bidwatc
>
> rev 1.71:
> ~~~~~~~~~
> 134 proces655441 running, 131 sle 0.07,  0.06,  0.07    up 7+00:10:59  17:17:48
> 145 states:    1% user,    42 nice,     % system,     % interrupt,     % idle
> Mem: 165M Ac 0.0, 2571M  0.0t, 226M  0.4d, 127M Ca 0.4 112M Buf, 1299.2ree
> Swap:20050M Total, 608Used, 375058Free       0                   25M Free
>
>   PID USERNAME      THR PRI NICE   SIZE    RES STATE  C   TIME   WCPU    CPU COMMAND
> 51029 obrien          1  96    0 64112K 62048K select 1   6:13  0.00%  0.00% Xo
>   283 root            1  96    0  1796K  1296K select 1   5:05  0.00%  0.00% na
> 51301 obrien          1  96    0 13508K  2156K select 1   5:01  0.00%  0.00% xc
>  1627 bind            1  96    0  4356K  3572K select 0   4:29  0.00%  0.00% na
> 51313 obrien          1  96    0  9920K  6356K select 0   2:28  0.00%  0.00% bi

Your USERNAME column is too wide (12 columns).  Do you happen to have
very long names?

If that is true, would it be ok to wait 1-2 days until I have a
machine.c version that prints USERNAME using only 8 columns instead of
using arbitrarily long columns, like now?

- Giorgos