cvs commit: src/sys/kern subr_bus.c subr_rman.c vfs_subr.c src/sys/net if_mib.c src/sys/netinet ip_divert.c raw_ip.c udp_usrreq.c

[M. Warner Losh]

In message: <20050506032202.GC2670 at funkthat.com>
            John-Mark Gurney <gurney_j at resnet.uoregon.edu> writes:
: Colin Percival wrote this message on Fri, May 06, 2005 at 02:48 +0000:
: > cperciva    2005-05-06 02:48:21 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/kern             subr_bus.c subr_rman.c vfs_subr.c 
: >     sys/net              if_mib.c 
: >     sys/netinet          ip_divert.c raw_ip.c udp_usrreq.c 
: >   Log:
: >   If we are going to
: >   1. Copy a NULL-terminated string into a fixed-length buffer, and
: >   2. copyout that buffer to userland,
: >   we really ought to
: >   0. Zero the entire buffer
: >   first.
: >   
: >   Security: FreeBSD-SA-05:08.kmem
: 
: /me notes this is a good reason to use strncpy instead of strlcpy.

Don't you mean the opposite?

Warner