cvs commit: src/sys/dev/ixgb if_ixgb.c if_ixgb.h if_ixgb_osdep.h

[Maxime Henrion]

mux         2005-03-30 23:08:46 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_5)
    sys/dev/ixgb         if_ixgb.c if_ixgb.h if_ixgb_osdep.h 
  Log:
  MFC if_ixgb.c r1.6 to r1.7, if_ixgb.h r1.4 and if_ixgb_osdep.h r1.3:
    Fix a bunch of bugs I came accross when looking at the ixgb(4) driver,
    some of which are rather serious:
    - Use the device sysctl tree instead of rolling our own.
    - Don't create a bus_dmamap_t to pass to bus_dmamem_alloc(), it is
      bus_dmamem_alloc() that creates it itself.  The DMA map created
      by the driver was overwritten and its memory was leaked.
    - Fix resource handling bugs in the error path of ixgb_dma_alloc().
    - Don't use vtophys() to get the base address of the TX and RX rings
      when busdma already gave us the correct address to use!
    - Remove now useless includes and the alpha_XXX_dmamap() hack.
    - Don't initialize if_output to ether_output(), ether_ifattach() does
      it for us already.
    - Add proper module dependencies on ether and pci.
  
  Tested by:      Paul Willmann willmann at rice dot edu
  Approved by:    re@ (kensmith)
  
  Revision  Changes    Path
  1.3.2.1   +9 -32     src/sys/dev/ixgb/if_ixgb.c
  1.2.4.1   +0 -7      src/sys/dev/ixgb/if_ixgb.h
  1.1.4.1   +0 -2      src/sys/dev/ixgb/if_ixgb_osdep.h