cvs commit: src/sys/dev/ixgb if_ixgb.c if_ixgb.h if_ixgb_osdep.h

[Maxime Henrion]

mux         2005-03-27 16:38:08 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/ixgb         if_ixgb.c if_ixgb.h if_ixgb_osdep.h 
  Log:
  Fix a bunch of bugs I came accross when looking at the ixgb(4) driver,
  some of which are rather serious:
  - Use the device sysctl tree instead of rolling our own.
  - Don't create a bus_dmamap_t to pass to bus_dmamem_alloc(), it is
    bus_dmamem_alloc() that creates it itself.  The DMA map created
    by the driver was overwritten and its memory was leaked.
  - Fix resource handling bugs in the error path of ixgb_dma_alloc().
  - Don't use vtophys() to get the base address of the TX and RX rings
    when busdma already gave us the correct address to use!
  - Remove now useless includes and the alpha_XXX_dmamap() hack.
  - Don't initialize if_output to ether_output(), ether_ifattach() does
    it for us already.
  - Add proper module dependencies on ether and pci.
  
  Unfortunately, I'm not lucky enough to own an ixgb(4) card, nor a
  machine with a bus where to plug it in and I couldn't find anyone able
  to test these patches, so they are only build-tested and I won't MFC
  them for 5.4-RELEASE.
  
  Revision  Changes    Path
  1.6       +9 -32     src/sys/dev/ixgb/if_ixgb.c
  1.4       +0 -7      src/sys/dev/ixgb/if_ixgb.h
  1.3       +0 -2      src/sys/dev/ixgb/if_ixgb_osdep.h