cvs commit: src/sys/dev/twa twa.c

Sam Leffler sam at errno.com
Sat Mar 26 16:33:26 PST 2005


Sam Leffler wrote:
> sam         2005-03-27 00:29:37 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/twa          twa.c 
>   Log:
>   check copyin+copyout return values when processing TWA_IOCTL_GET_LOCK
>   
>   Noticed by:     Coverity Prevent analysis tool

Note that several places in this routine copyin failures are ignored and 
user supplied data appears to be used w/o validation.  I'm not sure if 
these ioctls are accessible only to root but someone should cleanup this 
stuff.

	Sam


More information about the cvs-src mailing list