cvs commit: src/sys/i386/conf GENERIC src/sys/amd64/conf GENERIC

Bruce Evans bde at zeta.org.au
Wed Mar 16 17:37:27 PST 2005


On Wed, 16 Mar 2005, David O'Brien wrote:

> On Wed, Mar 16, 2005 at 09:54:06PM +0100, Pawel Jakub Dawidek wrote:
>> On Wed, Mar 16, 2005 at 08:23:31PM +0000, David E. O'Brien wrote:
>> +> -device		pcn		# AMD Am79C97x PCI 10/100 (precedence over 'lnc')
>> +> +device		nve		# nVidia nForce MCP on-board Ethernet Networking
>> +> +device		pcn		# AMD Am79C97x PCI 10/100(precedence over 'lnc')
>> [...]
>> +> -device		pcn		# AMD Am79C97x PCI 10/100 (precedence over 'lnc')
>> +> +device		nve		# nVidia nForce MCP on-board Ethernet Networking
>> +> +device		pcn		# AMD Am79C97x PCI 10/100(precedence over 'lnc')
>>
>> Why you removed this space?!:)
>
> Make it clear nve needs mii, and shorten long comment line.
>                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Better remove the bogus quotes around lnc.  Quoting elsewhere in this
file is inconsistent and about 1/4 of it seems to be bogus.

Are the comments on precedence even correct?  I think precedence
according to ordering in the config file hasn't worked for many years.
PCI devices may (should) have precedence over ISA ones, but that is a
general property and should be expressed better.  I think pcn may or
may not have precedence over lnc depending on resource conflicts.  pcn
is PCI-only while lnc is PCI/ISA/CBUS, so it is bogus for lnc to be
in the ISA-only section and very unclear how pcn has precedence over
the PCI part of lnc.

Bruce


More information about the cvs-src mailing list