cvs commit: src/sys/compat/linux linux_socket.c

Brian Fundakowski Feldman green at freebsd.org
Wed Mar 9 05:39:57 GMT 2005


On Wed, Mar 09, 2005 at 02:09:37AM +0200, Maxim Sobolev wrote:
> Looks fine, though it's hard for me to comment about adding yet another 
> flag that not present in standards. However, in my pretty 
> unauthoritative opinion, since Linux has it, while many people and ISVs 
> out there use it as a sort of reference when developing  free software, 
> it will probably make sense to support it as well, especially 
> considering that it's pretty easy to do.
> 
> In any case, since it's definitelty an API/ABI change (programs that use 
> MSG_NOSIGNAL won't compile on older systems, while binary programs that 
> use it may not work correctly on older systems) it also warrants 
> __FreeBSD_version bump and proper documentation in the Porter's 
> Handbook. Also the ABI argument probably puts MFC out of question.
> 
> Thanks!

Do you need to bump it when #ifdef can already serve that purpose?

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\


More information about the cvs-src mailing list