cvs commit: src/sys/dev/esp esp_sbus.c ncr53c9x.c

[David O'Brien]

On Wed, Mar 02, 2005 at 08:57:57AM -0700, Scott Long wrote:
> Scott Long wrote:
> >scottl      2005-03-02 15:56:42 UTC
> >  FreeBSD src repository
> >  Modified files:
> >    sys/dev/esp          esp_sbus.c ncr53c9x.c 
> >  Log:
> >  The existing locking in the esp driver appears to be fairly adequate, so
> >  set the interrupt handler to be INTR_MPSAFE now that xpt_done() can be
> >  called without Giant.  Giant is still on the top half of the driver and
> >  the timeout handlers.
> >  
> >  Revision  Changes    Path
> >  1.9       +1 -1      src/sys/dev/esp/esp_sbus.c
> >  1.8       +0 -2      src/sys/dev/esp/ncr53c9x.c
> 
> My Ultra2 now has no [GIANT-LOCKED] messages at all during boot and
> seems to run without any problems.  I haven't done any performance
> measurements yet, and enabling mpsafevfs will probably negate most
> improvements that this might have given, but it's a start.
> 
> David O'brien:  THIS IS NOT A FREEBSD 5.4 CANDIDATE.  It's a shame that
> I'll need to postfix all of my commits from now on with this message.

No f*cking sh*t locking changes aren't MFC candidates.
Is this now a personal cursade of yours to argue over any costmetic
changes I make?

-- 
-- David  (obrien at FreeBSD.org)