cvs commit: src/usr.sbin/pkg_install/add extract.c src/usr.sbin/pkg_install/create pkg_create.1 src/usr.sbin/pkg_install/info show.c src/usr.sbin/pkg_install/lib lib.h plist.c

[Maxim Sobolev]

Any chance that my concerns will be addressed by the brand new 
pkg_install maintainer?

-Maxim

Maxim Sobolev wrote:
> Well, while it can have some semantical value, but it is noop
> right now due to the absence of upgrade mechanism for older
> releases. Nobody will use it until such mechanism is introduced.
> 
> Also, this commit is incomplete since it doesn't include proper
> bumps in PKG_INSTALL_VERSION and PLIST_FMT_VER_MAJOR. This
> is major plist change since older pkg_install tools will
> not be able to handle packages with @noinst.
> 
> Another problem is that the name has been selected poorly IMHO,
> since "noinst" doesn't mean "do not install this", but in
> fact something like "do not package this", since there is
> no point to package some file which isn't going to be installed
> anyway. Therefore I'd suggest to change name to nopack along
> with version bump.
> 
> -Maxim
> 
> On Tue, Jun 14, 2005 at 10:17:12PM +0200, Kirill Ponomarew wrote:
> 
>>On Tue, Jun 14, 2005 at 06:54:56PM +0300, Maxim Sobolev wrote:
>>
>>>What's the purpose of such feature? I can't guess any.
>>
>>The purpose is to separate the meanings of these two fields, I was
>>agree with flz that @comment sounds a little strange in relation to
>>files, @noinst is more appropriate in this case.  However @comment
>>will stay anyway and serve for real comments, md5 sums etc.
>>
>>
>>>Kirill Ponomarew wrote:
>>>
>>>>krion       2005-06-14 15:05:43 UTC
>>>>
>>>> FreeBSD src repository
>>>>
>>>> Modified files:
>>>>   usr.sbin/pkg_install/add extract.c 
>>>>   usr.sbin/pkg_install/create pkg_create.1 
>>>>   usr.sbin/pkg_install/info show.c 
>>>>   usr.sbin/pkg_install/lib lib.h plist.c 
>>>> Log:
>>>> Implement @noinst field which has at the moment the same meaning and
>>>> function as @comment has.  But will be valid only for files and not
>>>> for md5 sums, rcsid's and comments in the future.
>>>> 
>>>> Submitted by:   flz
>>>> Approved by:    re@ (scottl)
>>>> 
>>>> Revision  Changes    Path
>>>> 1.43      +2 -1      src/usr.sbin/pkg_install/add/extract.c
>>>> 1.66      +10 -0     src/usr.sbin/pkg_install/create/pkg_create.1
>>>> 1.38      +4 -0      src/usr.sbin/pkg_install/info/show.c
>>>> 1.56      +2 -1      src/usr.sbin/pkg_install/lib/lib.h
>>>> 1.49      +6 -0      src/usr.sbin/pkg_install/lib/plist.c
>>>>
>>>>
>>>>
>>>
>>-Kirill
>>
>>
> 
> 
> 
>