cvs commit: src/sbin/dhclient - Imported sources

[David O'Brien]

On Wed, Jun 08, 2005 at 10:18:52AM -0700, Brooks Davis wrote:
> On Wed, Jun 08, 2005 at 10:02:27AM -0700, John Baldwin wrote:
> > On Jun 6, 2005, at 9:05 PM, Brooks Davis wrote:
> > >brooks      2005-06-07 04:05:09 UTC
> > >  FreeBSD src repository
> > >  src/sbin/dhclient - Imported sources
> > >  Update of /home/ncvs/src/sbin/dhclient
> > >  In directory repoman.freebsd.org:/tmp/cvs-serv49480
> > >
> > >  Log Message:
> > >  Import the OpenBSD dhclient as shipped with OpenBSD-3.7 (the tag
> > >  OPENBSD_3_7).
> > >
> > >  Vendor Tag:	OPENBSD
> > >  Release Tags:	dhclient_openbsd_3_7
> > 
> > Is there a reason this wasn't imported into src/contrib/dhclient?  Are 
> > we not going to import any future updates from OpenBSD?  Having vendor 
> > code in src that's not in src/contrib and src/crypto is very 
> > non-intuitive as people think that stuff outside of those directories 
> > is free to hack on and not regard vendor branches, etc.  If this is a 
> > one-shot import that is ok I guess.
> 
> We will take some future changes from OpenBSD, but we will also be
> modifying the code to suit out APIs and needs.  As such, I felt
> src/sbin/dhclient was a better location because I don't want to treat it
> as some untouchable gift from the gods of code the way we tend to do
> with things in contrib.

Since the OpenBSD dhclient is a branch of the ISC version 2 dhclient, it
would have been "cleaner" to have resurrected the ISC version 2 client in
src/contrib/dhclient and then imported the OpenBSD code.  This would make
it easy to see the development of our dhclient (the reason we care about
SCM history).  It would also have pulled every file off the vendor branch
so you would have also achieved the "change these files as needed" goal.
 
-- 
-- David    (obrien at FreeBSD.org)