cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7

[Alexander Leidinger]

On Sun, 31 Jul 2005 09:31:59 +0200
des at des.no (Dag-Erling Smørgrav) wrote:

> Alexander Leidinger <netchild at FreeBSD.org> writes:
> > What's more preferred, the use of ".error", or the way you solved it?
> 
> depends on what you think should happen if a user tries
> 
> # make installworld delete-old

Ok, point taken.

> BTW, I don't really see why {check,delete}-old-* should be restricted
> to native environments.  DESTDIR might point to e.g. an NFS-exported
> filesystem from which thin clients of a different architecture boot.

Because of ObsoleteFiles.inc:
---snip---
.if ${MACHINE_ARCH} != "alpha" && ${MACHINE_ARCH} != "sparc64"
# 20040130: libkse renamed to libpthread
OLD_FILES+=usr/lib/libkse.a
OLD_FILES+=usr/lib/libkse.so
.endif
---snip---

We could change this to TARGET_ARCH instead, but then the user has to
set it, else he removes non-obsolete files. Even when we make it a
documented requirement, I don't have a good feeling regarding this.
There's too much foot-shooting potential if someone forgets to set it.
I think it's more user friendly / ergonomic to keep the current
restriction. With the restriction in place you need to have 2
files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src
directory on one client to remove the old files. This is a little bit
more work, but forces the administrator to think a little bit about what
he does. It's part of my "as failsafe as possible" design of this
feature.

I don't object when someone wants to remove the restriction based upon
a decission of a majority (committers, user complains, whatever).

Bye,
Alexander.

-- 
                Where do you think you're going today?

http://www.Leidinger.net                       Alexander @ Leidinger.net
  GPG fingerprint = C518 BC70 E67F 143F BE91  3365 79E2 9C60 B006 3FE7