cvs commit: src/sys/pci if_xl.c
Andrew Gallatin
gallatin at cs.duke.edu
Thu Jul 14 13:09:04 GMT 2005
Gleb Smirnoff writes:
> On Thu, Jul 14, 2005 at 08:36:08AM -0400, Andrew Gallatin wrote:
> A> Gleb Smirnoff [glebius at FreeBSD.org] wrote:
> A> > glebius 2005-07-13 14:06:13 UTC
> A> >
> A> > FreeBSD src repository
> A> >
> A> > Modified files:
> A> > sys/pci if_xl.c
> A> > Log:
> A> > NET_LOCK_GIANT() when entering network code.
> A> >
> A>
> A> Do other drivers do this? It looks like at least em, fxp
> A> and my out-of-tree commercial driver have the same "bug".
>
> They do. Look at if_ath.c:ath_rx_proc(). This is done in functions
> that execute from a separate context - from task queue.
> em, fxp and others may not have such functions.
Ah, I hadn't realized that xl_rxeof() ran from a task queue. I'm not
sure I want to know why it does that ;)
Thanks for clearing that up.
Drew
More information about the cvs-src
mailing list