cvs commit: src/sys/compat/ndis subr_ntoskrnl.c
Scott Long
scottl at samsco.org
Fri Jul 8 21:24:36 GMT 2005
Maxim Sobolev wrote:
> Roman Kurakin wrote:
>
>> rik 2005-07-08 18:36:59 UTC
>>
>> FreeBSD src repository
>>
>> Modified files:
>> sys/compat/ndis subr_ntoskrnl.c Log:
>> Use implicit type cast for ->k_lock to fix compilation of ndis
>> as a part of the GENERIC kernel with INVARIANT* and WITNESS*
>> turned off.
>
>
> I think the better fix is to change type of k_lock member from void* to
> the struct mtx*, I've already commited such change to the RELENG_5 few
> days ago.
>
> -Maxim
It's a void* for portability with other OS's. This work has already
been ported
to Solaris, and maybe even other OS's by now. Reducing the portability is a
bad idea, and will likely get you smacked around by Bill when he
notices. I'd
highly recommend not doing this again in the future.
Scott
More information about the cvs-src
mailing list