cvs commit: src/sys/kern sys_generic.c

[Poul-Henning Kamp]

In message <20050125094226.GA28188 at nagual.pp.ru>, Andrey Chernov writes:
>On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote:
>>     sys/kern             sys_generic.c 
>>   Log:
>>   Previously a read of zero bytes got handled in devfs:vop_read() but I
>>   missed that when the vnode bypass was introduced.
>>   
>>   Deal with zero length transfers before we even get to fo_ops->fo_read().
>
>Please back it out. Zero bytes read may affect atime, now not.

No way.

That would be just as bogus as the fact that open(2) doesn't affect atime.

That is currently under discussion for reconsideration btw:

Today atime is not affected if you open and mmap a file.

Likewise I belive sendfile would not update atime either.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.