cvs commit: src/sys/kern sys_pipe.c

[Mike Silbersack]

On Mon, 17 Jan 2005, John Baldwin wrote:

> On Monday 17 January 2005 02:56 am, Mike Silbersack wrote:
>>   Rearrange the kninit calls for both directions of a pipe so that
>>   they both happen before pipe backing allocation occurs.  Previously,
>>   a pipe memory shortage would cause a panic due to a KNOTE call
>>   on an uninitialized si_note.
>>
>>   Reported by:    Peter Holm
>>   MFC after:      1 week
>
> Good catch!
>
> -- 
> John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/

I hope you mean good catch on Peter's part, not mine.  To create the 
panic, all I had to to was create a simple program which calls pipe 
repeatedly; I should have written / committed that program back when I was 
working on pipes last...

I'm going to commit my simple test program when I get a chance, and see if 
I can write modified versions to test the other allocation failure cases 
as well.

Mike "Silby" Silbersack