cvs commit: src/sys/netgraph ng_base.c src/sys/sys kernel.h

[Scott Long]

Simon L. Nielsen wrote:

> On 2005.01.10 10:41:39 -0800, John-Mark Gurney wrote:
> 
>>Maksim Yevmenkin wrote this message on Thu, Jan 06, 2005 at 17:45 +0000:
>>
>>>  This does not address the bigger problem: MODULE_DEPEND
>>>  does not seem to work when modules are compiled in the
>>>  kernel, but it fixes the problem with Netgraph Bluetooth
>>>  device drivers reported by a few folks.
>>
>>The real problem is that MODULE_DEPEND only documents other kernel
>>dependancies, but does not reorder SYSINIT's...  Considering that
>>SYSINIT's are always suppose to be ordered properly (otherwise, what
>>is the point of SYSINIT's) when staticly linked, having SYSINIT's not
>>properly ordered is the only bug...
>>
>>If we move to a more complex and module aware system of SYSINIT's, then
>>it might happen, but this will be very difficult considering that when
>>staticly linked, you have no way to seperate which SYSINIT's belong to
>>which modules...
>>
>>So, to everone, MODULE_DEPEND only marks which modules are required
>>for this module to work, it does not infulence startup ordering at
>>all...
> 
> 
> So, should I commit this patch?
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: MODULE_DEPEND.9
> ===================================================================
> RCS file: /home/ncvs/src/share/man/man9/MODULE_DEPEND.9,v
> retrieving revision 1.6
> diff -u -d -r1.6 MODULE_DEPEND.9
> --- MODULE_DEPEND.9	7 Jan 2005 08:44:31 -0000	1.6
> +++ MODULE_DEPEND.9	10 Jan 2005 20:23:23 -0000
> @@ -28,7 +28,7 @@
>  .\"
>  .\" $FreeBSD: src/share/man/man9/MODULE_DEPEND.9,v 1.6 2005/01/07 08:44:31 keramida Exp $
>  .\"
> -.Dd January 7, 2005
> +.Dd January 10, 2005
>  .Dt MODULE_DEPEND 9
>  .Os
>  .Sh NAME
> @@ -69,3 +69,7 @@
>  .An -nosplit
>  This manual page was written by
>  .An Alexander Langer Aq alex at FreeBSD.org .
> +.Sh BUGS
> +.Nm
> +only marks which modules are required for the module to work, it does
> +not influence start-up ordering.

It also is used by the loader and by kldload to load the dependent 
modules.  So it's more than just an informational tag, it actually does
get used by the system.

Scott