cvs commit: src/sys/netinet in_pcb.c

[Ruslan Ermilov]

On Tue, Feb 22, 2005 at 07:39:15AM +0000, Gleb Smirnoff wrote:
> glebius     2005-02-22 07:39:15 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/netinet          in_pcb.c 
>   Log:
>   In in_pcbconnect_setup() remove a check that route points at
>   loopback interface. Nobody have explained me sense of this check.
>   It breaks connect() system call to a destination address which is
>   loopback routed (e.g. blackholed).
>   
>   Reviewed by:    silence on net@
>   MFC after:      2 weeks
>   
>   Revision  Changes    Path
>   1.159     +2 -4      src/sys/netinet/in_pcb.c
> 
From reading the code and Stevens TCP/IP Ill. (which doesn't make
things more clear), I think the intent of this code was to select
the "best" route such that an address selected could be routed
over the network.  But I don't think this is appropriate behavior
and I like your change.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20050222/624d222d/attachment.bin