cvs commit: src/sys/ufs/ufs ufs_vnops.c

[Ken Smith]

On Wed, Feb 02, 2005 at 12:21:38AM +0000, Ken Smith wrote:
> kensmith    2005-02-02 00:21:38 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/ufs/ufs          ufs_vnops.c 
>   Log:
>   It was noticed that we do not change a file's access time when it gets
>   executed.  This appears to violate most of the UNIX-ish standards.
>   One example quote from:
>   
>     http://www.opengroup.org/onlinepubs/009695399/functions/exec.html
>   
>       Upon successful completion, the exec functions shall mark for update
>       the st_atime field of the file. If an exec function failed but was
>       able to locate the process image file, whether the st_atime field is
>       marked for update is unspecified. Should the exec function succeed,
>       the process image file shall be considered to have been opened with
>       open().
>   
>   This appears to take care of it for ufs filesystems, doing the necessary
>   sanity checks (read-only filesystem, etc) without violating any other
>   standards (setting atime for any open appears to be allowed in any standards
>   I could find).
>   
>   Noticed by:     cperciva
>   Reviewed by:    kan, rwatson
>   
>   Revision  Changes    Path
>   1.261     +6 -0      src/sys/ufs/ufs/ufs_vnops.c

A similar fix is in the works for ext2fs, I just need to test it a bit
more.

I don't know if this sort of thing should be MFCed, advice is welcome.
It's a user visible change in something that has probably been this
way for a long time but the current situation violates standards...

-- 
						Ken Smith
- From there to here, from here to      |       kensmith at cse.buffalo.edu
  there, funny things are everywhere.   |
                      - Theodore Geisel |