cvs commit: src/etc/periodic/daily 470.status-named

[Yar Tikhiy]

On Tue, Nov 22, 2005 at 10:24:28PM +0000, Doug Barton wrote:
> dougb       2005-11-22 22:24:28 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/periodic/daily   470.status-named 
>   Log:
>   Update the test for failed zone transfers to reflect BIND 9.3.1 semantics
>   Simplify the shell scripting a bit, and remove a useless grep | sed
>   
>   The problem was pointed out by the PR, and I used part of the solution
>   suggested there, but the semantics changed again for 9.2.x -> 9.3.x.
>   
>   PR:             conf/74228
>   Submitted by:   Jeremy Chadwick <freebsd at jdc.parodius.com>
>   
>   Revision  Changes    Path
>   1.7       +8 -10     src/etc/periodic/daily/470.status-named

Excuse me for this late comment, but using `fgrep -E' looks odd
to me because `fgrep' and `grep -E' are orthogonal and mutually
exclusive.  I mean the following part of the change:

-	    fgrep '^'"$start"'.*named\[[[:digit:]]\+\]: denied [AI]XFR from \[.*\]\.[[:digit:]]\+ for' | \
-	    sed -e 's/.*: denied [AI]XFR from \[\(.*\)\]\.[[:digit:]]* for "\(.*\)".*$/\2 from \1/'
+	    fgrep -E ".*named\[[[:digit:]]+\]: transfer of .*failed .*: REFUSED" |
+	    sed -e "s/.*transfer of \'\(.*\)\/IN\' from \(.*\)#[0-9]*: .*/\1 from \2/" |

In the older version it was just broken as it passed a regexp
to plain fgrep.  Now it should work, but still looks strange.

-- 
Yar