cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7

[Jeremie Le Hen]

Hi,

On Wed, Aug 03, 2005 at 12:11:50PM +0200, Alexander Leidinger wrote:
> "M. Warner Losh" <imp at bsdimp.com> wrote:
> 
> >In message: <20050802140536.zstn68rcgsg84g0w at netchild.homeip.net>
> >           Alexander Leidinger <netchild at FreeBSD.org> writes:
> >: When an user calls delete-old with DESTDIR set to the root of a 
> >non-native
> >: machine architecture he may remove non-obsolete files when he 
> >forgets to set
> >: TARGET_ARCH. I want to prevent this situation. I think "failsafe" is more
> >: important than "POLA" in this case.
> >
> >If TARGET_ARCH is set, then the right set of files will be deleted if
> >you use TARGET_ARCH rather than MACHINE_ARCH.
> 
> Yes. I'm not talking about technical problems. I talk about problems which
> sit on a chair. If we change MACHINE_ARCH to TARGET_ARCH and an user runs
> "make delete-old-libs" without setting TARGET_ARCH in a cross-arch
> environment, he will remove non-obsolete libs. And I think we should go the
> failsafe route.
> 
> If you think we can life with this problem, go ahead and change MACHINE_ARCH
> to TARGET_ARCH. But add an explanation to the commit log which makes it
> obvious that you understand the problem I'm talking about and that we
> (FreeBSD) don't care about it. And be prepared that I will whine at the
> person which makes this change when someone shoots in his foot when he
> forgets to set TARGET_ARCH.

What about making TARGET_ARCH mandatory if DESTDIR is different from "/" ?

Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >