cvs commit: src/share/mk bsd.libnames.mk src/lib/bind config.mk src/lib/bind/bind Makefile src/lib/bind/bind9 Makefile src/lib/bind/dns Makefile src/lib/bind/isc Makefile src/lib/bind/isccc Makefi

[Ruslan Ermilov]

On Fri, Sep 24, 2004 at 06:16:54PM +0000, Bjoern A. Zeeb wrote:
> On Fri, 24 Sep 2004, Doug Barton wrote:
> 
> > Kris Kennaway wrote:
> > > On Fri, Sep 24, 2004 at 01:42:00PM +0000, Ruslan Ermilov wrote:
> > >
> > >
> > >>  Log:
> > >>  Don't expose BIND libraries and their headers to the public by default,
> > >>  but have a knob (WANT_BIND_LIBS) to build and install them in /usr/lib
> > >>  and /usr/include.  Rumors are that this may be useful at a later point,
> > >>  let's see.
> > >
> > >
> > > The naming of this is inconsistent with the ports collection: WANT_*
> > > variables are for internal port use only, and may not be set by the
> > > user.  User control switches are in the WITH_*/WITHOUT_* namespace.
> >
> > Argh, thanks. I had this thought in the back of my mind, but got it
> > backwards. We'll get this fixed.
> 
> well actually for the base system shouldn't things be named NO_* ?
> So NO_BIND_LIBS in addition to NO_BIND would be better with but with
> a default to false instead of true ?
> It's confusing anyway because it's the other way round things are
> normally used but ENABLE_BIND_LIBS doesn't sound to be an option either.
> 
These NO's aren't boolean, they are ".if defined" variables.  I can
offer renaming it to INSTALL_BIND_LIBS, this sounds less confusing
than WANT_BIND_LIBS.  Doug, are you happy with INSTALL_BIND_LIBS?


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040924/0e0ea109/attachment.bin