cvs commit: src/sys/net if.c

[Brooks Davis]

On Wed, Sep 22, 2004 at 11:30:07AM -0400, Brian Fundakowski Feldman wrote:
> On Wed, Sep 22, 2004 at 08:01:05AM -0700, Brooks Davis wrote:
> > On Wed, Sep 22, 2004 at 09:00:52AM -0400, Brian Fundakowski Feldman wrote:
> > > On Wed, Sep 22, 2004 at 08:59:42AM +0000, Brooks Davis wrote:
> > > > brooks      2004-09-22 08:59:42 UTC
> > > > 
> > > >   FreeBSD src repository
> > > > 
> > > >   Modified files:
> > > >     sys/net              if.c 
> > > >   Log:
> > > >   Fix a LOR where ifconf() used copyout while holding a mutex.  This LOR
> > > >   was seen when configuring addresses on interfaces using ifconfig.  This
> > > >   patch has been verified to work with over eight thousand addresses
> > > >   assigned to an interface.
> > > >   
> > > >   LOR id:         031
> > > 
> > > You really need to be running with INVARIANTS if you plan on committing
> > > kernel code, or people are likely to get angry when their systems crash
> > > for stupid reasons.
> > 
> > Sorry about that.  Pass the pointy had please. :-(
> 
> No hard feelings, since I'm used to having a new issue or two every kernel
> upgrade, but this really should be a lesson to anyone listening that kernel
> development without INVARIANTS (and sometimes WITNESS) is a big no-no.

Yah, I've added INVARIANTS back to my laptop kernel in perforce to avoid
this particular mistake in the future.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040922/f4f5336c/attachment.bin