cvs commit: src/sys/i386/i386 gdb_machdep.c src/sys/i386/include db_machdep.h

[Stephan Uphoff]

Hi,

your patch fixes the same problem concerning breakpoints in
ddb. However by always using kdb_frame the wrong IP will
be read when looking at different threads in ddb.

	Stephan

On Wed, 2004-09-15 at 19:39, Brian Fundakowski Feldman wrote:
> On Wed, Sep 15, 2004 at 11:26:49PM +0000, Julian Elischer wrote:
> > julian      2004-09-15 23:26:49 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/i386/i386        gdb_machdep.c
> >     sys/i386/include     db_machdep.h
> >   Log:
> >   Fix breakpoint handling for i386.
> >           not sure yet about 5.x... MFC if needed.
> >   Also fixes small problems with examining some registers and
> >   some specific gdb transfer problems.
> >
> >           As the patch says:
> >           This is not a pretty patch and only meant as a temporary
> >           fix until a better solution is committed.
> >
> >   PR:             i386/71715
> >   Submitted by:   Stephan Uphoff <ups at tree.com>
> >   MFC after:      1 week
> 
> What about this change I'm still using with KDB so that break points
> don't crash my system as immediately?
> 
> --- include/db_machdep.h	10 Jul 2004 23:47:19 -0000	1.18
> +++ include/db_machdep.h	27 Aug 2004 23:14:12 -0000
> @@ -35,7 +35,7 @@
>  typedef	vm_offset_t	db_addr_t;	/* address - unsigned */
>  typedef	int		db_expr_t;	/* expression - signed */
> 
> -#define	PC_REGS()	((db_addr_t)kdb_thrctx->pcb_eip)
> +#define	PC_REGS()	((db_addr_t)kdb_frame->tf_eip)
> 
>  #define	BKPT_INST	0xcc		/* breakpoint instruction */
>  #define	BKPT_SIZE	(1)		/* size of breakpoint inst */
> 
> --
> Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
>   <> green at FreeBSD.org                               \  The Power to Serve! \
>  Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\
> _______________________________________________
> cvs-src at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-src
> To unsubscribe, send any mail to "cvs-src-unsubscribe at freebsd.org"
> 
>