cvs commit: src/sys/conf newvers.sh

[Ruslan Ermilov]

On Fri, Sep 03, 2004 at 08:25:17PM -0400, Ken Smith wrote:
> On Sat, Sep 04, 2004 at 12:23:10AM +0000, Ken Smith wrote:
> > kensmith    2004-09-04 00:23:10 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:        (Branch: RELENG_5)
> >     sys/conf             newvers.sh 
> >   Log:
> >   Another forced commit with no approval line, hoping this time it fails.
> >   
> >   Revision  Changes    Path
> >   1.62.2.6  +0 -0      src/sys/conf/newvers.sh
> 
> Ok, the line for RELENG_5 looking different than the rest of the lines
> in the approvers file was my best guess at why the approval checks
> weren't working.  Anyone else got any ideas?
> 
I played with this a bit, setting up a local repository with FreeBSD
CVSROOT scripts, and I cannot reproduce it.  Committing to RELENG_5
of newvers.sh (which was copied from the FreeBSD repo) results in the
following:

: cvs commit: Examining .
: Use of uninitialized value in sprintf at /home/ru/XXX/CVSROOT/commitcheck line 44.
: 2508 Repos: src/sys/conf
: 2508 ==== src/sys/conf/newvers.sh
: 2508 Tag: RELENG_5
: 2508 Avail: /home/ru/XXX/CVSROOT/avail
: 2514: pgrp: 2504
: 2514: committer: ru
: 2514: args: /home/ru/tmp/cvsSx1Z4U
: 2514: log: 
: 2514: files_file: tag=RELENG_5, file=src/sys/conf/newvers.sh
: 2514: Read /home/ru/XXX/CVSROOT/approvers
: 2514: checking: ^src/, RELENG_5, re
: 2514: file matched (src/sys/conf/newvers.sh, ^src/)
: 2514: tag matched (RELENG_5, RELENG_5)
: 2514: log not matched (
: , re)
: **** You need "Approved by: re" line in your log entry.
: cvs [commit aborted]: Message verification failed

I think that CVSROOT/approvecheck needs to have some debugging
until the problem is resolved.  Perhaps it cannot read the
$FILES_FILE for some reason, so the check is skipped, I don't
know how to trigger it.

Nothing looks suspicious at a glance.  :-(


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040904/726126f0/attachment.bin