cvs commit: src/lib/libsmb Makefile

[Ruslan Ermilov]

Hi David,

First, apologies for not sending you a HEADS UP.  I wanted to do it
but forgot.

On Sun, Oct 24, 2004 at 11:39:24PM -0700, David O'Brien wrote:
> On Sun, Oct 24, 2004 at 10:42:15AM +0000, Ruslan Ermilov wrote:
> > ru          2004-10-24 10:42:15 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     lib/libsmb           Makefile 
> >   Log:
> >   -O2 compile isn't quite ready for WARNS=2 yet.
> 
> Would you PLEASE let me fix my own problems OR send me a direct email
> that you reverted my commit??  I just spent 30 minutes trying to
> reproduce the tender box errors on two different machines.  Which had me
> puzzled since I saw no changes to contrib/smbfs since my commit.
> 
Ahem, our friend tinderbox was broken for five days.

> Hum... you know... should I go to Core about you backing out my commit??
> Since we don't officially support a userland at -O2 I wonder what the
> justification of your commit is...
>    
Don't we?  This is what's now in our make.conf(5) manpage:

:      CFLAGS        (str) Controls the compiler setting when compiling C code.
:                    Optimization levels other than -O and -O2 are not sup-
:                    ported.  BDECFLAGS is provided as a set of gcc(1) settings
:                    suggested by Bruce Evans <bde at FreeBSD.org> for developing
:                    and testing changes.  They can be used, if set, by:
: 
:                          CFLAGS+=${BDECFLAGS}

So it clearly looks to me like -O2 is "officially supported".

It's not about backing out your commit, it's about fixing a build breakage
which was ignored for five days.  Again, sorry for not sending you a HEADS
UP, but I needed a tinderbox service up and running as I planned a massive
makefiles commit.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041025/13358877/attachment.bin