cvs commit: src/sys/i386/isa pbio.c

[David O'Brien]

On Sat, Oct 09, 2004 at 09:01:03PM -0600, M. Warner Losh wrote:
> In message: <200410090831.i998VLD6076466 at repoman.freebsd.org>
>             "David E. O'Brien" <obrien at FreeBSD.org> writes:
> : obrien      2004-10-09 08:31:21 UTC
> :
> :   FreeBSD src repository
> :
> :   Modified files:
> :     sys/i386/isa         pbio.c
> :   Log:
> :   style(9)
>
> Thanks for obsoleting the busspace changes that I was working on.

I assume this said sarcastically... I think this is a little harsh.
I wish you had mentioned publicly that you were going to busspace it.
In the thread when it was committed to HEAD and noticed this driver used
depreciated interfaces, it was said it shouldn't be too hard to use
proper interfaces -- but I didn't see a commitment to do the work.

I wasn't sure what a 'pbio' driver was so I went to read the code and
noticed it had inconsistent style (and had some style(9) compliancy
issues).  Thus I fixed it.

As I said I think it is a little harsh to take the position your work is
killed.  You can (1) copy your sys/i386/isa/.#pbio.c.1.1 to pbio.c and
continue your work, sending me your finished file and I'll re-style(9) it
before committing.  (2) commit your busspace'ification to RELENG_4 and
I'll cvs merge it from the branch.

--
-- David  (obrien at FreeBSD.org)