cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h

[Nate Lawson]

Takanori Watanabe wrote:
> In message <41644415.3030402 at root.org>, Nate Lawson wrote:
> 
>>>I think ACPI-CA itself can override any SSDT by checking existing
>>>SSDT header passed to AcpiOsTableOverride.
>>
>>I'm not sure what you mean here but I agree that AcpiOsTableOverride() 
>>should be able to decide whether to override an SSDT or not.  All I'm 
>>asking for is a special return code from AcpiOsTableOverride() that 
>>means "ignore this table completely" so I don't have to provide a fake 
>>empty table to get this effect.
> 
> The thing I want to say is like this. 
> In this code, I intended to be able to override arbitaly table 
> on a system, though I have never run it. And if iASL can accept
> ASL file with multiple DefinitionBlock, you don't need to compound
> all SSDT's into DSDT: all you have to do is concatinate SSDT 
> with DefinitionBlock to the tail of DSDT dump.
> I think this approach is far more extensive, though I don't 
> deny current approach as a workaround.

Ah, I understand.  I think this approach is fine since acpidump would 
maintain the ordering from the XSDT, and the order in the ASL file of 
the DefinitionBlocks would determine which tables are overridden.  This 
is definitely cleaner than our current approach and similar in that if 
you want to override one DSDT/SSDT table, you have to override them all 
(even if it's with the original contents for unmodified tables.)

The only tough modification for this is for iasl(8) to be able to handle 
multiple DefinitionBlock entries in a single file.  On the acpidump 
side, we can just run iasl -d multiple times and concatenate the results.

-- 
Nate