cvs commit: src/sys/sys pbioio.h src/sys/i386/isa pbio.c src/sys/conf files.i386 src/sys/i386/conf NOTES

M. Warner Losh imp at bsdimp.com
Thu Oct 7 12:59:19 PDT 2004


In message: <20041007190453.GA82804 at ns1.xcllnt.net>
            Marcel Moolenaar <marcel at xcllnt.net> writes:
: On Thu, Oct 07, 2004 at 12:20:05PM -0600, M. Warner Losh wrote:
: > In message: <20041007175206.GA82275 at ns1.xcllnt.net>
: >             Marcel Moolenaar <marcel at xcllnt.net> writes:
: > : On Thu, Oct 07, 2004 at 04:21:03PM +0000, Warner Losh wrote:
: > : > imp         2004-10-07 16:21:03 UTC
: > : > 
: > : >   FreeBSD src repository
: > : > 
: > : >   Modified files:
: > : >     sys/conf             files.i386 
: > : >     sys/i386/conf        NOTES 
: > : >   Added files:
: > : >     sys/sys              pbioio.h 
: > : >     sys/i386/isa         pbio.c 
: > : >   Log:
: > : >   Port pbio to HEAD.
: > : 
: > : I appreciate your speed, but don't you think that pbioio.h is pretty
: > : MD given that the driver only exists on i386. Wouldn't <machine/pbioio.h>
: > : be a better place?
: > 
: > I think that pbioio.h is MI.  What makes you think that it is pretty
: > MD?
: 
: Because pbio(4) only exists on i386. Hence, all other platforms now
: have <sys/pbioio.h> that serves no purpose and can only cause
: autoconfiguration (ala autoconf) getting confused. Since pbioio.h
: refers to hardware, it nature is MD, even though the definitions
: (types and interfaces) may appear MI. So, <machine/bpioio.h> seems 
: like a good place.

But we've had lots of problems in the past where MD drivers became MI
drivers with 10 identical copies of machine/fooio.h.  The driver
likely copy become MI relatively easily.

Warner


More information about the cvs-src mailing list